goutamadwant commented on PR #12478:
URL: https://github.com/apache/seatunnel/pull/12478#issuecomment-5848011832

   Thanks for the review. I merged `dev` (no force push) and trimmed the PR to 
what `dev` doesn't cover:
   
   1. **Images:** test classes now match `dev` (`ghcr.io/teableio/minio`); 
`bitnamilegacy` is gone. What's left is the benchmark compose, which uses the 
same digest for `minio` and `minio-init`, because `minio/mc` no longer allows 
anonymous pulls 
([L148-L167](https://github.com/apache/seatunnel/blob/7b3cdfeba720fc591ca021db5a88a8e269eebd23/seatunnel-cli/benchmark/docker/docker-compose.yml#L148-L167)).
   2. **Databend:** `DatabendIT` and `DatabendCDCSinkIT` passed on the previous 
head ([JDK 
8](https://github.com/goutamadwant/seatunnel/actions/runs/36181020922/job/108226814955),
 [JDK 
11](https://github.com/goutamadwant/seatunnel/actions/runs/36181020922/job/108226815066)).
 This PR no longer touches them.
   3. **Wait strategy:** comment added 
([L80-L83](https://github.com/apache/seatunnel/blob/7b3cdfeba720fc591ca021db5a88a8e269eebd23/seatunnel-e2e/seatunnel-connector-v2-e2e/connector-file-s3-e2e/src/test/java/org/apache/seatunnel/e2e/connector/file/s3/S3FileWithFilterIT.java#L80-L83)).
   4. **Shared constant / Apache mirror:** left for a separate PR if wanted.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to