SEPURI-SAI-KRISHNA commented on PR #12444:
URL: https://github.com/apache/seatunnel/pull/12444#issuecomment-5853336353
Following up on the red badge here, since it is the last visible objection
to merging this and it is not what it looks like.
The two failing legs are both `ubuntu`, both fail inside
`seatunnel-engine-server`, and they fail on two different tests, neither of
which this PR can reach. Its diff is one file: `PayPalClientTest.java`.
```
unit-test (11, ubuntu-latest)
TaskExecutionServiceTest.testStaleTaskDoneCleansOnlyOwnedGenerationResources:639
-> #12394 "[Test][Zeta] Isolate task execution fixture identities", open
unit-test (8, ubuntu-latest)
EngineStateStoreLogicalMetricExportsTest
.collectShouldExportLogicalMetricsForSpecialStateStores:109
expected: <2.0> but was: <0.0>
-> #12453 "[Test][Zeta] Await asynchronous logical checkpoint metrics",
open
```
The part that matters for this PR is what happened on the same run:
```
unit-test (8, windows-latest) success
unit-test (11, windows-latest) success
```
Both Windows legs passed. That is the platform where `closeWakesRetryWait`
fails everywhere else, including on `dev` and on three of my own PRs. And
`PayPalClientTest` itself ran green on all four legs, 23 of 23 on each of the
two ubuntu jobs as well.
So the evidence for this change is: the mechanism is understood and
conceded, @goutamadwant measured 0 of 50 normally and 0 of 20 with the body
write forced to throw, and its own CI is green on the platform in question
while the only red is two unrelated engine tests that already have their own
PRs open.
I have no stake in how the engine flakes are handled, but they should not be
what holds this one up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
