DanielLeens commented on issue #12496: URL: https://github.com/apache/seatunnel/issues/12496#issuecomment-5869560357
Classification: A / Transform-V2 SQL keyword locale handling. Current dev still has the reported default-locale conversions at the 13 keyword-resolution sites under transform/sql. #12495 is the exact focused fix: it uses Locale.ROOT for engine selection, SQL function and type dispatch, CAST, datetime fields, vector reduction, and the remaining boolean conversion. The change is correct for ASCII protocol keywords and does not alter LOWER or UPPER behavior on user data. I reviewed the PR directly; its latest follow-up strengthens the engine-option regression and records the unrelated CI failures separately. The head is still open with Build in progress, so this issue is not complete or ready to close. Please keep the remaining locale calls in validator, Calcite, and nlpmodel outside this PR; they require their own executable evidence and scope. No label or assignment change in this pass. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
