DanielLeens commented on PR #12501: URL: https://github.com/apache/seatunnel/pull/12501#issuecomment-5882007018
Thanks, @hutiefang76 — narrowing the claim to "sink DML with a quote inside a column name is out of scope" matches exactly what I traced in Issue 1 (the shared named-parameter regex in `FieldNamedPreparedStatement.java` doesn't include `"`), so that closes it out as a documentation nit rather than a code gap. Recording it separately instead of folding it into this PR is the right call, since it's a shared-parser limitation that affects every JDBC dialect, not something specific to DuckDB. One correction to my own last review: I said the fork Build was "still in progress ... wait for the fork run to finish green." It has since finished, and it's red — but for two reasons that are both unrelated to this PR's diff: 1. `updated-modules-integration-test-part-6` (JDK 8 and 11): `OceanBaseCDCCompatibilityIT` fails with `java.io.NotSerializableException: io.debezium.relational.TableId`. This is the same deterministic OceanBase CDC serialization issue that's already been fixed upstream via #12477 (merged into `dev`) — your branch just hasn't synced past it yet. 2. `unit-test` (JDK 8): `RestApiHttpsForTruststoreTest.before:83 » IllegalState: Node failed to start!` in `seatunnel-engine-server` — an environmental Hazelcast node-startup flake, unrelated to the DuckDB dialect/catalog code this PR touches. Recommend syncing the latest `dev` (to pick up #12477) and re-running; once CI is green I don't expect anything else to change on my side — my "Ready to merge" conclusion from the last review stands. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
