DanielLeens commented on PR #12378: URL: https://github.com/apache/seatunnel/pull/12378#issuecomment-5882035779
Thanks @davidzollo for the encouraging look, and thanks for keeping this moving, @zhangshenghang! Just flagging status for anyone tracking this thread: the current head (`48eebda5a`) is still exactly the commit I reviewed on Sep 18, so the two Medium-severity blockers from that review are still open: - **Issue 1:** the leftover manual `## Changelog` / `### next version` (or `## 变更日志` / `### 下一版本`) block hasn't been removed from the six moved files yet, so each page still renders two "Changelog" headings back to back. - **Issue 2:** the four new changelog files (`connector-facebook-ads.md`, `connector-google-ads.md`, en + zh) still lack the `<details><summary> Change Log </summary>...</details>` wrapper and a content row that every sibling connector's changelog file has. Both are mechanical, quick fixes confined to the same set of files — once they're in, this is a clear merge from my side. Happy to take another pass as soon as they're pushed! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
