Rangsh commented on issue #12492: URL: https://github.com/apache/seatunnel/issues/12492#issuecomment-5883691536
Thanks @DanielLeens — appreciated, and fully understood. I'll keep the revised failure-class design as the agreed direction only (not an implementation go-ahead), and I will not start this dependent PR until #12081 is green, merged, and this follow-up is rebased on that baseline. Separately, #12081 is now synced to latest `dev` with a fresh Build in flight. Recording the before-coding contract here: - **Already-queued APPENDs:** best-effort complete with failure (`done(false)` / permanent-block); do not leave them timeout-only. - **Later APPENDs:** observe sticky permanent fail-close immediately, without calling `write(...)`. - **Rethrow boundary (v1):** after best-effort completion + fail-close, rethrow `VirtualMachineError` (incl. `OutOfMemoryError`), `ThreadDeath`, `LinkageError`, and any other non-enumerated `Error`. No `Error` is recoverable in v1; do not silently resume the consumer or reopen the writer. - **Regression:** safe synthetic `Error` only — never a real OOM test. Happy to tighten this further if helpful; otherwise I'll wait on the #12081 gate before coding. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
