Rangsh commented on PR #12493: URL: https://github.com/apache/seatunnel/pull/12493#issuecomment-5883954014
@DanielLeens @Vivek1106-04 @SEZ9 Thank you for the careful reviews and for spelling out the two bugs that a correct drain-off-lock fix exposes (SubPlan restore race + cut-short drain failure reason). Rather than keep a second, incomplete change for the same drain, I am closing this PR in favor of #12511, which already includes: 1. the unlocked drain + gate (part 1 of #12441), 2. mapping every cut-short drain to `CHECKPOINT_COORDINATOR_SHUTDOWN` on the coordinator side (so JobMaster keeps the never-started / retryable contract), and 3. the SubPlan restore re-check with the matching `SavePointTest` regression. I will review #12511 and help get it green rather than compete with it. Happy to take review comments or small follow-ups there if useful. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
