det101 opened a new pull request, #12549:
URL: https://github.com/apache/seatunnel/pull/12549

   ## Purpose
   
   Fixes #12548
   
   SeaTunnel CLI encourages `${MYSQL_USER}` / `${MYSQL_PASSWORD}` placeholders, 
but `validate_hocon()` treated any unset `${VAR}` as a hard `INVALID` error. 
That made generation and `/check` fail even when the config structure was fine 
and the placeholders were intentional.
   
   ## Changes
   
   - Default `validate_hocon()`: unset `${ENV}` (outside engine template 
fields) → **WARNING**, result can stay `VALID (with warnings)`
   - `/run`: call `validate_hocon(..., strict_env=True)` and **block 
execution** if required env vars are missing
   - `/check`: still PASS locally when only env warnings remain; surface 
WARNING lines in the UI
   - LLM validator system prompt: treat unset `${ENV}` as `PASS_WITH_NOTES`, 
not FAIL
   - Docs (en/zh) + unit tests for layered severity
   
   ## Verify
   
   ```bash
   cd seatunnel-cli
   .venv/bin/python -m pytest tests/test_validate_hocon_placeholders.py -q
   # 16 passed
   ```
   
   ## Docs
   
   - `seatunnel-cli/README.md`
   - `seatunnel-cli/README.zh-CN.md`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to