CodeWithPravinMaske commented on PR #12551: URL: https://github.com/apache/seatunnel/pull/12551#issuecomment-5890085675
Thanks a lot for the thorough review, @DanielLeens! Issue 1: Agreed. CloudWriter rewrites the current WAL object on every update, and GCS allows about one write per second to the same object name. I added a note to the IMap GCS sections (en/zh, separated and hybrid deployment) saying GCS IMap persistence is best suited to low or moderate update rates. The real-GCS run in the description covered checkpoint storage; IMap was verified against the emulator. Issue 2: Added a comment in the IMap GcsConfiguration explaining that the FileSystem cache is intentionally left at the Hadoop default, matching the existing IMap OSS/S3 configurations. Issue 3: Kept as is, following the per-module layout of the existing configuration tests. CI: the two red engine-v2-it jobs are known flaky ITs unrelated to this change: BackpressureSlowSinkIT.testCheckpointsKeepCompletingUnderSustainedBackpressure (Java 8, being fixed in [#12313](https://github.com/apache/seatunnel/issues/12313)) and SplitClusterFaultToleranceIT.testStreamJobCancelResolvesWhenWorkerCrashesBeforeCancelAck (Java 11, being fixed in [#12311](https://github.com/apache/seatunnel/issues/12311)). Re-running with the new commit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
