Nikk8091 opened a new pull request, #12572:
URL: https://github.com/apache/seatunnel/pull/12572

   ### Purpose of this pull request
   
   This PR handles the approved `connector-socket` Source slice of #11007 
(scope confirmation: 
https://github.com/apache/seatunnel/issues/11007#issuecomment-5917734796).
   
   `SocketSourceFactory.optionRule()` previously required `host` and `port` 
only for presence. It now rejects blank `host` values and nonpositive `port` 
values during factory validation. The Socket Sink and TCP reader are unchanged.
   
   ### Does this PR introduce _any_ user-facing change?
   
   Yes. A Socket Source configuration with an empty or whitespace-only `host`, 
or a zero or negative `port`, now fails during configuration validation instead 
of proceeding toward a connection attempt. Nonblank hosts, including values 
with surrounding spaces, remain accepted. The English and Chinese source option 
descriptions state these constraints.
   
   ### How was this patch tested?
   
   - Extended `SocketFactoryTest` with source factory cases for valid and 
padded nonblank `host`; missing `host` and `port`; empty, spaces-only and 
tab/newline-only `host`; and zero and negative `port`.
   - Confirmed the new blank-host and nonpositive-port tests fail against the 
original `SocketSourceFactory.optionRule()` before adding the rules (2 failures 
in 9 tests).
   - `mvn -o -pl seatunnel-connectors-v2/connector-socket verify` passed: 10 
tests, 0 failures or errors; compilation, formatting, packaging, and shading 
passed.
   - Repository-wide `mvn -o -q spotless:apply` passed and changed no unrelated 
files.
   - `git diff --check` passed.
   
   ### Check list
   
   * [x] Updated the English and Chinese Socket Source option documentation.
   * [x] Added focused factory validation tests.
   * [x] No new binary dependency or connector registration change; this 
updates an existing connector's configuration validation.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to