hutiefang76 commented on PR #12459:
URL: https://github.com/apache/seatunnel/pull/12459#issuecomment-5920027257

   The DuckDB unsigned rows here need coordination with #12508. This diff 
changes UTINYINT/USMALLINT/UINTEGER/UBIGINT to TINYINT/SMALLINT/INT/BIGINT to 
match the older converter, while #12508 fixes that narrowing and preserves the 
full unsigned ranges as SMALLINT/INT/BIGINT/DECIMAL(20,0). It also adds a 
paragraph documenting those widened mappings.
   
   If both PRs merge as currently written, the type table and the new paragraph 
will contradict each other. Could the unsigned-row changes retain the widened 
mappings when the range fix lands? The separate ARRAY/STRUCT/MAP → STRING and 
zoned-timestamp corrections are useful and do not need to be dropped.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to