hutiefang76 opened a new pull request, #12582:
URL: https://github.com/apache/seatunnel/pull/12582
### Purpose of this pull request
Fixes #12581. DuckDB type-name normalization uses the default locale, so
lowercase integer/tinyint/bigint names silently become STRING under tr-TR. Use
Locale.ROOT when matching the type name.
### Does this PR introduce _any_ user-facing change?
Yes. Supported type names match consistently regardless of case and JVM
locale. Unknown-type fallback and existing type mappings remain the same.
English and Chinese Source docs describe type-name matching.
### How was this patch tested?
The new tr-TR assertion fails on the original implementation with INT vs
STRING. On JDK 8 and 17, DuckDBTypeConverterTest, DuckDBDialectTest and
DuckDBSourceAndSinkTest pass 61 tests on each; MarkdownTest passes 4 on each.
No failures, errors or skips. The locale test checks lowercase/uppercase names,
BIT metadata length and unknown fallback, uses a locale resource lock, and
restores the locale in finally. Source/Sink and dialect controls execute real
DuckDB JDBC operations. These are local module tests, not an engine E2E or
full-suite result.
Scoped Spotless, reactor `-DskipTests verify`, and `git diff --check` pass.
No dependency, option, public signature or default is added.
### Check list
* [ ] If any new Jar binary package adding in your PR, please add License
Notice according
[New License
Guide](https://github.com/apache/seatunnel/blob/dev/docs/en/developer/new-license.md)
* [ ] If necessary, please update the documentation to describe the new
feature. https://github.com/apache/seatunnel/tree/dev/docs
* [ ] If necessary, please update `incompatible-changes.md` to describe the
incompatibility caused by this PR.
* [ ] If you are contributing the connector code, please check that the
following files are updated:
1. Update
[plugin-mapping.properties](https://github.com/apache/seatunnel/blob/dev/plugin-mapping.properties)
and add new connector information in it
2. Update the pom file of
[seatunnel-dist](https://github.com/apache/seatunnel/blob/dev/seatunnel-dist/pom.xml)
3. Add ci label in
[label-scope-conf](https://github.com/apache/seatunnel/blob/dev/.github/workflows/labeler/label-scope-conf.yml)
4. Add e2e testcase in
[seatunnel-e2e](https://github.com/apache/seatunnel/tree/dev/seatunnel-e2e/seatunnel-connector-v2-e2e/)
5. Update connector
[plugin_config](https://github.com/apache/seatunnel/blob/dev/config/plugin_config)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
