This is an automated email from the ASF dual-hosted git repository.
nzw921rx pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/seatunnel-website.git
The following commit(s) were added to refs/heads/main by this push:
new 52c00582bdae [Doc] Use 1 committer approval as the baseline for all
modules (#544)
52c00582bdae is described below
commit 52c00582bdaea18d9a1e24798b49278dffbf5f08
Author: Doyeon Kim <[email protected]>
AuthorDate: Fri Oct 2 00:50:16 2026 +0900
[Doc] Use 1 committer approval as the baseline for all modules (#544)
---
community/contribution_guide/code-review.md | 22 +++++++++++-----------
.../current/contribution_guide/code-review.md | 22 +++++++++++-----------
2 files changed, 22 insertions(+), 22 deletions(-)
diff --git a/community/contribution_guide/code-review.md
b/community/contribution_guide/code-review.md
index cb827f99f767..f04712f57f59 100644
--- a/community/contribution_guide/code-review.md
+++ b/community/contribution_guide/code-review.md
@@ -6,15 +6,21 @@ We expect reviewers and committers to follow this guidance
consistently, especia
## Approval policy for PRs targeting `dev`
-GitHub currently shows the `dev` branch as requiring only one approval before
merge. This is only the global branch protection baseline.
-
-For PRs that **do not** touch core modules, the merge baseline is:
+GitHub branch protection on `dev` requires one approval before merge. The same
baseline applies to all modules, including core modules such as `seatunnel-api`
and `seatunnel-engine`:
1. **One committer approval**
2. Passing automated bot checks, such as CI, code style, and license validation
-3. At least one collaborator or AI bot review, where applicable
-The following modules are considered core and therefore still require **two
committer approvals** before merge:
+A reviewer may ask for a **second committer review** when they consider a
change risky. This is based on the reviewer's judgment, not on which modules
the PR touches. Examples include:
+
+- Checkpoint or serialization format changes
+- Public API changes in `seatunnel-api`
+- Features proposed through a [STIP](./STIP.md)
+- Incompatible changes
+
+If a second committer review has been requested, do not merge the PR until
that review is given, even if GitHub reports that the required review check has
passed.
+
+For PRs that touch core modules, committers are encouraged to wait at least 24
hours after approval before merging, so that committers in other time zones
have a chance to review the change or request a second review. This is a
recommendation, not a merge requirement. The core modules are:
- `seatunnel-api`
- `seatunnel-engine/seatunnel-engine-core`
@@ -24,12 +30,6 @@ The following modules are considered core and therefore
still require **two comm
- `seatunnel-engine/seatunnel-engine-serializer`
- `seatunnel-engine/seatunnel-engine-storage`
-All other modules, including connectors, transforms, e2e tests, documentation,
and tooling, follow the relaxed baseline above as long as they do not modify
any of the core modules listed here.
-
-This policy is determined by **module scope**, not by the number of changed
files or lines of code. If a PR touches any core module, the stricter **two
committer approvals** rule applies to the whole PR.
-
-GitHub cannot enforce this per-module rule automatically today, so reviewers
and committers must inspect the changed files manually. If a PR touches core
modules but does not yet have two committer approvals, do not merge it even if
GitHub reports that the required review check has passed.
-
## General review checklist
1. Check whether the PR title follows project conventions and accurately
describes the change.
diff --git
a/i18n/zh-CN/docusaurus-plugin-content-docs-community/current/contribution_guide/code-review.md
b/i18n/zh-CN/docusaurus-plugin-content-docs-community/current/contribution_guide/code-review.md
index c5725bc652c8..72c6549b241c 100644
---
a/i18n/zh-CN/docusaurus-plugin-content-docs-community/current/contribution_guide/code-review.md
+++
b/i18n/zh-CN/docusaurus-plugin-content-docs-community/current/contribution_guide/code-review.md
@@ -6,15 +6,21 @@
## 面向 `dev` 分支 PR 的审批规则
-GitHub 当前展示的 `dev` 分支合并门槛是只需要 1 个 approval。但这只是全局分支保护的基础要求。
-
-对于**不涉及 core 模块**的 PR，合并基线为：
+GitHub 对 `dev` 分支的分支保护要求合并前至少有 1 个 approval。所有模块都遵循同一合并基线，包括 `seatunnel-api` 和
`seatunnel-engine` 等 core 模块：
1. **1 个 committer approval**
2. 自动化检查通过，例如 CI、代码风格检查和许可证校验
-3. 在适用的情况下，至少有 1 个 collaborator 或 AI bot review
-以下模块被视为 core 模块，因此仍然要求 **2 个 committer approvals** 后才能合并：
+如果 reviewer 认为某个改动风险较高，可以要求**第二位 committer 进行 review**。这取决于 reviewer 的判断，而不是
PR 修改了哪些模块。例如：
+
+- checkpoint 或序列化格式的变更
+- `seatunnel-api` 中公开 API 的变更
+- 通过 [STIP](./STIP.md) 提出的功能
+- 不兼容变更
+
+如果已经要求了第二位 committer review，在该 review 完成之前不要合并，即使 GitHub 显示 review check 已经通过。
+
+对于涉及 core 模块的 PR，建议 committer 在 approval 之后至少等待 24 小时再合并，以便其他时区的 committer 有机会
review 该改动或要求第二位 committer review。这是一项建议，而不是合并的必要条件。core 模块包括：
- `seatunnel-api`
- `seatunnel-engine/seatunnel-engine-core`
@@ -24,12 +30,6 @@ GitHub 当前展示的 `dev` 分支合并门槛是只需要 1 个 approval。但
- `seatunnel-engine/seatunnel-engine-serializer`
- `seatunnel-engine/seatunnel-engine-storage`
-其他模块，包括 connectors、transforms、e2e tests、documentation 和 tooling，只要没有修改上面列出的任何
core 模块，就遵循前面的放宽基线。
-
-这条规则按**模块范围**判断，而不是按修改文件数或代码行数判断。只要一个 PR 触及任意 core 模块，整条 PR 就必须遵循 **2 个
committer approvals** 的更严格规则。
-
-由于 GitHub 当前还不能自动按模块范围强制执行这条规则，因此 reviewer 和 committer 需要手动检查改动文件。如果一个 PR 触及了
core 模块，但还没有拿到 2 个 committer approvals，即使 GitHub 显示 review check 已经通过，也不要合并。
-
## 通用评审检查项
1. 检查 PR 标题是否符合项目规范，是否准确表达了改动内容。
