CodeWithPravinMaske commented on PR #12597: URL: https://github.com/apache/seatunnel/pull/12597#issuecomment-5969591651
Thanks a lot for the detailed review, @DanielLeens! - **Issue 1:** added unit tests for the default `JdbcDataSourceDialect#isColumnNullable` with a mocked `DatabaseMetaData`: `IS_NULLABLE=YES` / `NO`, the fallback to `Column#isOptional()` when no row matches, and a row matched only by the LIKE pattern (`noXpk` for `no_pk`) that must be ignored. With the exact-name check removed, the pattern test fails. - **Issue 3:** the WARN messages now say how to restore parallel snapshot reading (declare a NOT NULL unique column or configure a non-nullable `snapshotSplitColumn`). - **Issue 2:** agreed, I kept the schema-based check in this PR since a data-dependent probe or an `IS NULL` chunk has snapshot/binlog consistency implications. Happy to look at an `IS NULL` chunk as a follow-up. This commit also triggers a fresh CI run, since the previous attempt was cancelled at the website job. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
