goutamadwant commented on PR #12587: URL: https://github.com/apache/seatunnel/pull/12587#issuecomment-5973756306
> Thanks for the fix. One small compatibility concern: in PostgresSourceFetchTaskContext.configure(), the new pre-check calls snapshotter.shouldStream() before snapshotter.init(...). > > The built-in snapshotters return a constant here, so normal configurations are unaffected. However, a custom snapshotter configured through debezium.snapshot.mode = custom may depend on state populated by init(). This earlier call could then fail during startup even with a healthy slot, or return a default false and skip the check. > > Could we avoid calling shouldStream() before initialization while keeping the invalidation check ahead of getReplicationSlotState()? A focused regression test with a custom snapshotter that depends on initialization would help cover this case. @nzw921rx Thanks, good catch. addressed it. pls have a re-look and let me know. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
