SEZ9 commented on PR #11912: URL: https://github.com/apache/seatunnel/pull/11912#issuecomment-5976031011
Thanks for keeping this moving. Quick status from my side: - Since head 3add4380ae the only new commit is the merge of upstream dev (5673b261ca), and the branch now has a merge conflict with dev — as nzw921rx also flagged, please resolve that first so we can re-review a clean head. When you re-merge, please double-check that none of the PR's own changes in `MultiTableSink.java` and the new `SchemaChangeApplier` / `SupportCoordinatedSchemaEvolutionSink` SPI files get lost or double-applied in the process. Once the conflict is resolved, could you also give a short per-item status on the earlier findings so I can close them out? 1. **PR11912-F1 / F2 / F7** – eager per-table `SchemaChangeApplier` creation on every parallel writer in `MultiTableSink`: is the applier now created lazily (only when coordinated schema evolution is actually in use), or is that still open? 2. **PR11912-F3** – `createSchemaChangeApplier(TablePath)` resolving the target sink nondeterministically when several logical tables map to one physical table, plus the logical-fullName vs physical-path key mismatch: has the keying been unified? 3. **PR11912-F4** – `SchemaChangeApplier` javadoc: please state the identifier-safety expectations for implementers, since the DDL is source-derived. 4. **PR11912-F6** – enforcing (or at least failing fast on) the "writers must implement `SupportSchemaRefreshSinkWriter`" contract instead of relying on javadoc only. 5. **PR11912-F5 / F8** – docs: a short concept/dev-guide update for coordinated schema evolution and an upgrade note on checkpoint/savepoint restore for schema-evolution jobs. If any of these were already addressed in the merge commit, just point me at it and I'll re-check. Thanks! <!-- streview-comment:1504 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
