nankeChen75 commented on PR #12616: URL: https://github.com/apache/seatunnel/pull/12616#issuecomment-5977204225
Thanks for the detailed review. I pushed an update addressing the four follow-ups: 1. `TimeStampMicroTZConverter` now uses the timezone declared by the Arrow field, falling back to `ZoneId.systemDefault()` only when it is absent. 2. Added `TimeStampNanoTZConverter` so `TIMESTAMPNANOTZ` no longer falls through to the millisecond fallback path. 3. Added class-level Javadocs documenting the epoch units, timezone semantics, and the reason for using `floorDiv` / `floorMod`. 4. Updated the regression test to use nullable MicroTZ/NanoTZ vectors, cover the null path, and use a declared timezone that differs from the JVM default timezone. The updated `ArrowToSeatunnelRowReaderTest` passes locally on JDK 8. The latest head is `9562c71327c8`. Thanks again for the review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
