SEPURI-SAI-KRISHNA commented on PR #12595: URL: https://github.com/apache/seatunnel/pull/12595#issuecomment-5981288260
Both done, and the full run has now finished. **1. Javadoc note.** `ad78cbc8e` adds four lines to `credentialMatches`, all inside the existing comment block: > Verified against the OpenJDK 8u source and the JDK 17 bytecode. Both fold the length difference into the accumulator and run the loop for the full length of the first argument, so neither returns early on a length mismatch. **2. The rerun you asked about is green.** Build `36849854713` on `8de4031fa`, the commit carrying the actual fix, finished attempt 3 at 2026-10-03 17:43 UTC with `conclusion: success`: 81 jobs passed, 13 skipped, none failed. The three jobs @DanielLeens flagged all passed on that attempt: | job | result | | --- | --- | | `unit-test (8, windows-latest)` | success | | `all-connectors-it-7 (8, ubuntu-latest)` | success | | `doris-connector-it (8, ubuntu-latest)` | success | **The javadoc push started a fresh full Build, `37184991698`.** It finished 79 success, 13 skipped, 1 failed, 1 cancelled. Neither is reachable from this diff: - `engine-v2-it (8)` failed on `BackpressureSlowSinkIT.testCheckpointsKeepCompletingUnderSustainedBackpressure`, the only failing test in that job. That is the flake @DanielLeens documented in #12313 as failing on `dev` itself, same `only observed N (samples=[...])` signature. #12313 and #12316 are both still open. It ran 105 minutes against a 150 minute limit, so it is a test failure rather than a timeout. - `all-connectors-it-2 (8)` was cancelled by its 150 minute timeout, not by a test failure: its log contains no failing test. `PulsarMultiTableIT` started at 10:49:04, logged its last broker activity at 10:56:12, then idled until the cut at 12:30:46. The JDK 11 leg of the same run passed in 85 minutes, and this job succeeded on the five preceding runs at 113 to 120 minutes, so it looks like a one-off hang rather than a budget problem. Happy to open a separate issue for it if you would like, since it is unrelated to this PR. On whether this diff could cause either: the commit on this head adds four lines and every one is inside a `/** */` block, so the bytecode is unchanged. In the failing `engine-v2-it (8)` job `BasicAuthenticationIT` reported `Tests run: 9, Failures: 0, Errors: 0`. Happy to rerun both jobs if you would rather see the aggregate green, though #12313 will keep recurring until it is fixed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
