zhangshenghang opened a new pull request, #12652:
URL: https://github.com/apache/seatunnel/pull/12652
## Purpose of the pull request
Several engine (Zeta) e2e tests in `connector-seatunnel-e2e-base` wait with
fixed sleeps at points where the condition they actually need is directly
observable. Under CI load those conditions (job startup, log output, cluster
formation, log-file retention) arrive later than the fixed budget and the tests
fail intermittently; when the machine is fast, the same sleeps waste minutes.
This PR makes the waits condition-based while keeping every assertion unchanged:
- `CheckpointEnableIT`: the two `Thread.sleep(15000)` waits before
`assertTrue(getServerLogs().contains("checkpoint is enabled"))` are replaced
with `await().untilAsserted` polling of the same log-line assertion (60s
bound). The following `savepointJob`/exit-code assertions are untouched.
- `JobLogIT`: the fixed 90s wait before `assertFileLogClean(after)` is
replaced with `untilAsserted(assertFileLogClean(after))` (3min bound, 5s
interval) — the retained log file shows up asynchronously.
- `SeaTunnelSlotIT`: removed the three `Thread.sleep(2000)` calls placed
*inside* `untilAsserted` blocks right before the actual assertion. The
surrounding poll loop already provides the waiting; the inner sleeps only
slowed each poll down.
- `WorkerTagClusterTest`: same redundant in-poll sleep removed, and the
outer bound raised from 10s to 60s (with 1s interval) so slow cluster formation
/ worker registration no longer times out.
- `ClassLoaderITBase`: same redundant in-poll 10s sleep removed (poll
interval 1s added) — the members==1 assertion itself is the condition.
## Verification
- `./mvnw spotless:apply`
- `./mvnw -pl
seatunnel-e2e/seatunnel-engine-e2e/connector-seatunnel-e2e-base -am -DskipTests
package`
No assertion / expected value was changed — only how long and how often the
tests wait before evaluating them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
