SEZ9 commented on issue #12656: URL: https://github.com/apache/seatunnel/issues/12656#issuecomment-6029745991
Thanks for the detailed report and for offering to submit a PR. Since you've already inspected the in-tree callers and found they use throwing mode, please include a unit test in the PR that covers the non-throwing path with a non-retriable condition, asserting a single invocation and a null result. A short note in the PR about the behavior change for non-throwing mode would also help reviewers. <!-- streview-comment:1572 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
