SEPURI-SAI-KRISHNA commented on PR #12618:
URL: https://github.com/apache/seatunnel/pull/12618#issuecomment-6031355901
Both asks are done, @SEZ9.
**1. Refreshed onto current `dev`.** New head `4bbe8b329`, now zero commits
behind. I did this by merging `upstream/dev` rather than a true rebase, so the
existing review anchors on the PR are preserved; say the word if you would
rather have linear history and I will rebase and force push instead.
Nothing conflicted. Of the 13 `seatunnel-transforms-v2` files touched on
`dev` since the old base `309b15eff`, every one is under `metadata/` or
`sql/zeta/`, and this PR touches only `calcite`, `nlpmodel` and `validator`, so
there is no intersection at all. `seatunnel-transforms-v2` is green on the
merged head: `Tests run: 1228, Failures: 0, Errors: 0`, and `spotless:check`
passes.
**2. The eleven are the complete set.** Added to the PR description, and the
scan on the new head is:
```
$ git grep -nE "toUpperCase\(\)|toLowerCase\(\)" -- \
seatunnel-transforms-v2/src/main/java/org/apache/seatunnel/transform/{calcite,nlpmodel,validator}
(no matches)
```
83 `src/main` files across the three modules (27 calcite, 41 nlpmodel, 15
validator), and every one of the eleven now reads `Locale.ROOT`.
For the #12620 starting point you asked for: the same scan over all 228
`src/main` files of the module returns **13** remaining bare calls on this
branch, every one under `sql/`, which is #12495's scope. 13 plus 11 is 24,
matching the baseline enumerated on #12620, so the two PRs together take the
module to zero.
**On the rerun.** Noting it since it had already run before your comment,
and it turned out to be informative rather than blind. Attempt 2 of
`37140738764` on the same head `48599a8f6`: `transform-v2-it-part-1 (11)` and
`paimon-connector-it (8)` both went green, so `TestFilterRowKindIT` (#12116)
and `PaimonWithS3IT` (#11679) did not recur. The only remaining failure was
`engine-v2-it (11)`, on
`BackpressureSlowSinkIT.testCheckpointsKeepCompletingUnderSustainedBackpressure`,
197 tests with 1 failure and no runner shutdown signal in the log, so a
genuine recurrence of #12313 / #12316 rather than infrastructure. `Build
website` was cancelled at the 90 minute limit again, which #12614 addresses.
So the second run is the artifact you originally wanted: two of the three
tracked flakes cleared, and the third reproduced with its own tracked signature.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
