CodeWithPravinMaske commented on PR #12608:
URL: https://github.com/apache/seatunnel/pull/12608#issuecomment-6031678506
Thanks @SEZ9, both confirmed:
1. **Docs.** They already describe the new behaviour; nowhere do they say
NULL is still coerced to the type default.
- MySQL-CDC docs, "Read tables without a primary key" section
([en](https://github.com/apache/seatunnel/blob/fa70f3eb83f4252074dccd4137f1ac6bf22fa2d8/docs/en/connectors/source/MySQL-CDC.md?plain=1#L516),
[zh](https://github.com/apache/seatunnel/blob/fa70f3eb83f4252074dccd4137f1ac6bf22fa2d8/docs/zh/connectors/source/MySQL-CDC.md?plain=1#L509)):
NULL in a nullable unique key column, or in a nullable column configured in
`table-names-config.primaryKeys`, is emitted as NULL in the snapshot and binlog
phases, with a recommendation to use a NOT NULL key column when UPDATE/DELETE
must be applied by key.
- `incompatible-changes.md`
([en](https://github.com/apache/seatunnel/blob/fa70f3eb83f4252074dccd4137f1ac6bf22fa2d8/docs/en/introduction/concepts/incompatible-changes.md?plain=1#L8-L14),
[zh](https://github.com/apache/seatunnel/blob/fa70f3eb83f4252074dccd4137f1ac6bf22fa2d8/docs/zh/introduction/concepts/incompatible-changes.md?plain=1#L7-L13)):
promoted unique key columns now keep their declared nullability and NULL is
emitted as NULL, plus the sink impact and migration guidance.
2. **CI.** The restore E2E is green in CI on the head commit `fa70f3eb8`
([run](https://github.com/CodeWithPravinMaske/seatunnel/actions/runs/37420097470)).
In both `mysql-cdc-connector-it` jobs ([JDK
8](https://github.com/CodeWithPravinMaske/seatunnel/actions/runs/37420097470/job/112129448460),
[JDK
11](https://github.com/CodeWithPravinMaske/seatunnel/actions/runs/37420097470/job/112129448548)),
`testMysqlCdcNullInNullableUniqueKeyAfterRestore` passed, along with
`testMysqlCdcNullInNullableUniqueKeyWithoutPrimaryKey` on all 5 engine
containers. `MysqlCDCIT` ran 54 tests with 0 failures.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
