DanielLeens commented on issue #12669:
URL: https://github.com/apache/seatunnel/issues/12669#issuecomment-6037719586

   Thanks for the concise reproduction and for opening #12672. The serializer 
joins fields with the configured separator, so using a comma-default 
`CSVPrinter` to decide `MINIMAL` quoting is indeed inconsistent. I checked the 
corresponding reader path: it splits using the first configured delimiter 
character, so configuring the printer with that same character is the minimal 
compatible fix.
   
   The round trips for comma, pipe, tab and the control-character delimiter, 
together with quotes, line breaks and nulls, are useful because a 
row-count-only test would miss the column shift. The added LocalFile 
write/read/assert scenario is also the right end-to-end boundary; please ensure 
it is executed in the connector E2E run, not merely compiled. Multi-character 
delimiters remain outside this patch because the existing reader contract is 
character-based. The Build is queued, so keep the issue open pending CI and 
review.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to