det101 commented on PR #12545:
URL: https://github.com/apache/seatunnel/pull/12545#issuecomment-6051094140
Thanks @DanielLeens for the thorough review. Pushed a follow-up on this
branch (`4c9d3d57`) that addresses all five items:
1. **High — redaction weaker than CLI creds.** Extracted
`seatunnel_cli/credentials.py` and reuse it for both debug `redact_text` and
the LLM `${_CRED_N_}` placeholder swap. Quoted HOCON/JSON (`secret_key` /
`access_key` / `"password": "..."` / spaced single-quoted values) and token
shapes (Bearer / `sk-` / AKIA) go through the same matcher; `${...}`
placeholders are left intact.
2. **Medium — local validator always `fail`.** `_run_validator` now uses
`local_result.startswith("VALID")`, matching `validate_hocon`.
3. **Medium — unescaped Rich markup.** `_show_debug` prints `Text(...,
style=)` so snippets containing `[sink]` / `[/x]` are not parsed as markup.
4. **Medium — test isolation and coverage.** The autouse fixture resets the
module flag; added tests for the missing redaction shapes, `_run_validator`
`validator_detail` events, and markup-safe printing.
5. **Low — `enable_debug` mutating `os.environ`.** `--debug` now sets a
process-local `_enabled` flag. `SEATUNNEL_CLI_DEBUG=1` still works
independently.
Local: `python -m pytest tests` → 218 passed.
Please take another look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
