zhang-arvin commented on PR #12024: URL: https://github.com/apache/seatunnel/pull/12024#issuecomment-6051450734
@DanielLeens Thanks for the precise diagnosis. Fixed both items and pushed: 1. **Issue #1 (compile blocker)**: `rowCountQuery` is now declared `final` and assigned exactly once on each path (the analyze-fallback branch builds an intermediate `String query` and only assigns `rowCountQuery` once at the end). The lambda capture of `rowCountQuery` now compiles. 2. **Issue #2 (dead write)**: removed the `useSelectCount = true;` statement; the fallback now just reassigns the local query. Also de-duplicated the `select count(*)` format string into a single `selectCountQuery`. Verified locally with the project toolchain (JDK 8): `./mvnw -o compile -pl connector-cdc-oracle` passes, and `spotless:apply` is clean. New head: `692c6bda5`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
