zhang-arvin commented on PR #11883: URL: https://github.com/apache/seatunnel/pull/11883#issuecomment-6051742553
@DanielLeens Thanks for holding the line on Issue 1 — you're right that the fix reached for the validating accessor. Fixed as you suggested. Pushed head `3121d7fa6`. **Issue 1 (High, blocker) — resolved.** The no-collector `write()` path no longer calls `ConnectionPoolManager.getConnection()` (the validating/evicting accessor) per row. Instead: - `JdbcOutputFormat` now records the connection its statement executor was prepared with (`createAndOpenStatementExecutor()` and `updateExecutor()` both set it) and exposes `getExecutorConnection()`, which does **no** validation or eviction — safe on the write hot path. - `JdbcSinkWriter.write()`'s no-collector branch sets `transactionConnection = outputFormat.getExecutorConnection()`. So the tracking follows the connection actually bound to the executor, refreshed only when the executor reconnects, matching the pattern already used by the row-collector path. **Issue 3 (Medium) — done.** Documented `connectionTestQuery` / the HikariCP pool-property behavior in `docs/en/connectors/sink/Jdbc.md` and `docs/zh/connectors/sink/Jdbc.md` (which keys go to the pool vs. the driver DataSource, and how `connectionTestQuery` is used for validation). Verified locally: the module compiles and the pre-existing suites stay green — `ConnectionPoolManagerTest` `Tests run: 9, Failures: 0`, `JdbcSinkWriterTest` `Tests run: 9, Failures: 0`. `spotless:apply` clean. Still open: Issue 2 (a new test that exercises the stale-connection scenario through the no-collector `write()` path) and Issues 4-6 (Low) — happy to take those in a follow-up push; flagging so the state is explicit. (Also note the head moved `6e3ee70c3 -> 19bc4543a` via a rebase-only push while this was in flight; I rebased this change onto `19bc4543a`, so no prior work was dropped.) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
