davidzollo commented on PR #11613: URL: https://github.com/apache/seatunnel/pull/11613#issuecomment-6098558640
@DanielLeens thanks for the full re-review of `a125187dc`. Pushed `9dc0aed` for the two items you asked for before merge: - **Issue 1 (behavior change record)**: `docs/en|zh/introduction/concepts/incompatible-changes.md` now carry an "Engine Behavior Changes" entry for the restore guard: affected endpoints (`/submit-job`, `/submit-job/upload`, `/submit-jobs` with `restoreMode` + `restoreSourceJobId`), the old versus new behavior, the end states that are accepted (`FINISHED`, `FAILED`, `CANCELED`, `SAVEPOINT_DONE`), the note that an unknown job id still falls through to `No checkpoint found`, the unchanged legacy `isStartWithSavePoint` + `jobId` path, and the migration step (stop or savepoint-stop the source first). - **Issue 2 (guard wiring)**: `RestApiSubmitJobStartWithSavePointTest#testSubmitCheckpointRestoreFromActiveSourceJobReturns400` submits an unbounded FakeSource job over REST, waits until the coordinator reports `RUNNING`, posts `restoreMode=checkpoint&restoreSourceJobId=<that id>` and asserts the 400 with `restoreSourceJobId=<id> is still RUNNING`; it then stops the job via `/stop-job`, waits for an end state, repeats the request and asserts the guard no longer fires (either a new job is started and stopped, or the response is the `No checkpoint found` 400). Dropping the `rejectRestoreFromActiveSourceJob` call or the status lookup makes this test fail. - **Issue 3 (UI gating)** and **Issue 4 (screenshots)**: left open as non-blocking, as you suggested. CI remains gated on the fork owner's enable action on the fork's Actions page; nothing in `9dc0aed` has run in CI yet. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
