Rangsh commented on PR #12172: URL: https://github.com/apache/seatunnel/pull/12172#issuecomment-6146105301
@DanielLeens Thanks for the re-review and for pinning down both Low items precisely. Addressed in the latest push: 1. **Issue 1 (behavior note)**: updated the PR description under "Does this PR introduce _any_ user-facing change?" to state explicitly that a `DELETE` / `UPDATE_BEFORE` row without an `EventTime` option no longer emits the previous row's `ts_ms` (it now writes the current row's value, or `null` when absent). Envelope shape and all other fields are unchanged. 2. **Issue 2 (missing serializer test)**: added `DebeziumJsonSerDeSchemaTest#testSerializationSourceCacheAndEventTimeReset` to the existing class (no new test class). It asserts that (a) the cached `source` block is refreshed when the table id changes (`db1.sch1.t1` → `db2.sch2.t2`) and (b) a `DELETE` without an event time after an INSERT with one yields `ts_ms: null` rather than the previous value. Also synced the latest `dev`, which brings #12711 (the Elasticsearch slice-test fix). The branch is now `ahead 8 / behind 0` against `dev`. Local: `DebeziumJsonSerDeSchemaTest` is green (13 tests) and `spotless:apply` was run. Fresh CI on the fork is queued for the new head `1f5e56717`: - Fork run: https://github.com/Rangsh/seatunnel/actions/runs/38401334764 - PR: https://github.com/apache/seatunnel/pull/12172 I'll report back here if anything fails outside the previously-seen unrelated flakes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
