wgzhao commented on PR #12742: URL: https://github.com/apache/seatunnel/pull/12742#issuecomment-6146141900
Both points are addressed on `dbf78b817`. **Issue 1 (javadoc wording).** Reworded. The set is now described as computing its members from the `*_UNSIGNED` type names listed below by stripping ` UNSIGNED`, with the honest caveat spelled out: adding a numeric type still means declaring its constant *and* listing it, and `MySqlTypeConverterTest` reflects over the constants so the two cannot silently diverge. That is the accurate version of what the code does — `Stream.of(...)` is still hand-written, only the derivation of the base names is automatic. **Issue 2 (merge order / sync).** Merged `apache/dev` (`b0f6feddf`) into the branch, so the follow-up now sits on current `dev` instead of 8 commits behind it. It is still stacked on #12333, so it should land after that one. **Verification on the pushed head.** `MySqlTypeConverterTest` 47/47 green on JDK 17 (including `testGuardAcceptsEveryUnsignedTypeNameOfTheConverter`); `spotless:apply` clean; compilation of `connector-jdbc` against the refreshed `seatunnel-api` on current `dev` succeeds. **On the failed lane.** The only failing job in the earlier run was `updated-modules-integration-test-part-5 (17, ubuntu-latest)`. I did not re-pull the full lane log (it is large), but the test you named is in the tree exactly as you describe: `JdbcMySqlCreateTableIT` lives in `connector-jdbc-e2e-part-4` and starts the `mcr.microsoft.com/mssql/server:2022-latest` container. Neither that test nor that container is touched by this diff, so I agree with reading it as environmental. The push re-triggered `Build`; if the lane fails the same way again I will treat it as infra rather than keep cycling it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
