ryanmeowy commented on PR #12746: URL: https://github.com/apache/seatunnel/pull/12746#issuecomment-6147800418
Addressed both Low items in `91a73e510`: - later-entry coverage: a valid first `tables_configs` entry followed by one whose schema has no metadata now asserts `tables_configs[1].schema`; - nested `metadata_table_id`: a `tables_configs` entry whose nested schema declares only `metadata_table_id` is covered as accepted; - `testOptionRuleIsDeclared` is replaced by `testOptionRuleCarriesSchemaMetadataGuards`, which reads the constraints off `optionRule.getValueConstraints()` and asserts the schema, not-empty and selector guards are actually carried, instead of only checking that the options are declared as optional. I verified it has teeth by commenting out the root-schema registration locally and watching it fail with `missing root schema guard: [...]`. 21 tests pass locally on JDK 11 and `spotless:check` is clean. Build is running on this head. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
