Asthenia0412 commented on PR #12695:
URL: https://github.com/apache/seatunnel/pull/12695#issuecomment-6147078604
@DanielLeens Pushed fix (bf19ba8) addressing all three issues:
**Issue 1 (High) — factory options overwriting URI jms.***: the six
factory-level options now use `noDefaultValue()` instead of `defaultValue()`,
and `createConnectionFactory` only calls `factory.setX()` when the option was
explicitly set. Users putting `jms.useAsyncSend=true` or similar in the broker
URI are no longer silently clobbered.
**Issue 2 (Medium) — credentials in log**: the `log.info("broker url: ...")`
line now masks `user:password@` → `***@` before logging.
**Issue 3 (Low) — time_to_live int cap**: changed from `intType()` to
`longType()`. Also added range validation for `delivery_mode` (must be 1 or 2)
and `priority` (0–9).
FYI I only touched the factory setter guards, time_to_live type, and log
masking — no structural change to the constructor chain or close order. Let me
know if anything needs adjustment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
