SEZ9 commented on PR #11493: URL: https://github.com/apache/seatunnel/pull/11493#issuecomment-6160790311
Thanks for the CI update, @davidzollo. The root-cause analysis makes sense: adding the `TableSchema` overload turning the untyped `any()` ambiguous at `testCompile` lines up with the broad Build failure that was reported earlier, and switching to a typed `Mockito.<TableSchema>any()` matcher in `58d1cf0d19d` is the right fix. I'll wait for the freshly queued current-head Build to finish before drawing any conclusion about CI status. Agreed that this commit is scoped to the CI fix only, so the four earlier findings remain open. To make the next round concrete, here is what I'd still like to see for each: 1. **PR11493-F1 (HIGH, Compatibility)** – Snowflake `VARIANT`, Doris `JSON`/`JSONB` and StarRocks `JSON` source columns currently switch from `STRING` to the new JSON logical type with no opt-out. Please either add a config option that preserves the previous `STRING` mapping, or explicitly document this as an incompatible change in `docs/en/introduction/concepts/incompatible-changes.md` with the upgrade impact spelled out. Let me know which direction you prefer. 2. **PR11493-F2 (MEDIUM, Logic)** – Since the JSON logical type is physically a plain String, nothing stops non-JSON text from reaching a native JSON sink. Please clarify in `docs/en/introduction/concepts/schema-feature.md` where validation is expected to happen, and if the only check is at the StarRocks load boundary, either add validation closer to the type/sink layer or document that contract clearly. 3. **PR11493-F3 (MEDIUM, Robustness)** – StarRocks sink with native JSON columns plus the default CSV Stream Load format should fail at sink initialization rather than at load time. A fail-fast check with a clear error message, plus a note in `docs/en/connectors/sink/StarRocks.md`, would close this. 4. **PR11493-F4 (MEDIUM, Robustness)** – Snowflake sink with a user-defined query silently skips `PARSE_JSON` wrapping for JSON fields. Please either fail fast when JSON fields are present with a custom query, or document the limitation and the required manual `PARSE_JSON` in `docs/en/connectors/sink/Snowflake.md`. Once the queued Build result is in and the above are addressed (or you have a rationale for deferring any of them), ping me and I'll do another pass. <!-- streview-comment:1752 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
