SEZ9 commented on PR #11559: URL: https://github.com/apache/seatunnel/pull/11559#issuecomment-6183915428
Thanks for the follow-up on `PR11559-F1` — the linked `KafkaSourceReaderGateTest` results on run 37762854171 (JDK 8 job 113264137851 and JDK 11 job 113264137976, 7 tests, 0 failures/errors/skipped on head `522bedc2d25`) are the executed evidence I was asking for, and the two rejection cases you describe (`productionDeserializeSplitShouldRejectClassOutsideAllowlist` with `HashMap`, and `productionDeserializeSplitShouldRejectSamePackageSubclassOutsideAllowlist` with `KafkaSourceSplitState`) are what I wanted covered. The same-package subclass case in particular is the regression guard I was after, since it only fails under exact-name matching. Widening `deserializeSplit(byte[])` to package-private `static` for test access is acceptable to me as you've described it; please keep it `static` and package-private rather than public. I'll review the diff on `522bedc2d25` for `KafkaSourceReader.java` and the gate test directly before closing the finding, since I need to confirm the allowlist and test contents in the code itself rather than from the comment pointers. If the Kafka reader or its test changes after that head, please re-link the per-test job results for the new head as you offered. <!-- streview-comment:1776 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
