SEZ9 commented on PR #11500: URL: https://github.com/apache/seatunnel/pull/11500#issuecomment-6183968820
Thanks for the quick turnaround on `f5fd0fdd0`. Checking the earlier points against the new head: - **Test coverage for the new default** – the new `testSlotServiceDefaultsToStaticWhenSlotServiceBlockAbsent` case with `no-slot-service-seatunnel.yaml` pins the option default, the `SlotServiceConfig` initializer and a parse with no `slot-service` block, and it goes red if the flip is reverted. Good. The other half of that point was the shared e2e container configuration running on `dynamic-slot: true`. Could you confirm whether that config was changed on this head? If leaving it on dynamic slots is intentional for now, a short note in the PR description would help; otherwise flipping it (or adding one e2e path on the default) would be my preference. - **`-e local` slot cap** and **restore-after-upgrade path** – both are now covered in `incompatible-changes.md` (en + zh). That covers what I was after. - **separated-cluster-deployment 4.3 example** – flipped to match 4.2, consistent with the hybrid page. - **`slot-num: 20` reading as a default / zh k8s wording** – resolved by the "optional" comment and the aligned zh sentence. - **PR description mentioning the JDBC converter change** – removed, description now matches the diff. So five of the six earlier items are closed from my side, with the e2e configuration question above still open. I also see the latest review on this head reports two new merge-gate problems, so I'll hold off on a final verdict until those are addressed as well. <!-- streview-comment:1777 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
