88fantasy commented on PR #12208: URL: https://github.com/apache/seatunnel/pull/12208#issuecomment-6205620787
@DanielLeens Thanks for the re-review on `61ece4fae`. Addressed both non-blocking notes in `d10445a74` / `e64970e18`: - **Issue 1** — `prefersDorisOverJdbcWhenOptionsAlsoCarryAUrl` now uses a distinct JDBC URL (`jdbc:postgresql://other-host:5432/other_db`) so a JDBC-first order would fail the Doris namespace assertion (`mysql://fe.example:9030` / `ds71.orders`). - **Issue 2** — `LineageDatasetFactory.loadExtractors()` now catches `ServiceConfigurationError` from both `hasNext()` (break) and `next()` (skip), so a malformed provider file cannot poison class init. Also synced with latest `dev` on this branch. Happy to take another look when you have a moment. CI on the fork for this head and a committer Approve are still the remaining gates. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
