DanielLeens commented on PR #11900: URL: https://github.com/apache/seatunnel/pull/11900#issuecomment-6210068315
Quick status note for @zhang-arvin and @SEZ9 on head `94ada9982` (this is a thread update, not a new review: there is no new commit since my 2026-10-10 review, and my technical conclusion there is unchanged). @SEZ9 thanks for confirming F2/F3 are closed on this head. On the one item you still list, the shared-instance concern: it is the same point as my Issue 1 from the last review. In short, `testShutdownRunsBeforeThrowingCleanupStep` and `testShutdownRemovesListeners` should not run against the class-scoped server that `testlistJobState` / `testGetJobStatus` use. Option A (move the two destructive tests into their own small test class with its own Hazelcast instance) is the cleanest; Option B (restore state in a `finally` and wait for `isCoordinatorActive`) is the smaller change. @zhang-arvin, that is the only source-side item left on my side, so no extra rounds of review are needed once it lands. One CI fact from my last review has changed, so I am updating it so the earlier guidance does not go stale. I cited three infrastructure failures on the fork run for this head (`zhang-arvin/seatunnel` run 37724709072): the `Dead links` job (deepwiki.com 429), the minio-based connector ITs (`quay.io/minio/minio`) and `SplitClusterFaultToleranceIT`. The first two are fixed on `dev` now: #12639 (ignore deepwiki.com in the dead-link check, merged 2026-10-07) and #12287 (minio test containers moved to the `quay.io` mirror, merged 2026-09-13), and this branch is 211 commits behind `dev` and diverged, so it does not have them yet. `SplitClusterFaultToleranceIT` is still the dev-side flake tracked in #12311, which is still open, so that one may recur. Suggested next step: when you push the test-isolation change, please sync with the latest `dev` as well, then re-run only the failed jobs. If `Dead links` or the minio ITs still fail after the sync, please paste the new check link here and I will help narrow it down. Thanks again for sticking with this one; the production fix itself is in good shape. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
