DanielLeens commented on issue #10203:
URL: https://github.com/apache/seatunnel/issues/10203#issuecomment-6217825668

   Classification: A / Connector-V2 MySQL-CDC live table-admission and recovery 
correctness.
   
   Thank you for extending the design against the existing modes. The 
distinction is now clear: the live DDL-driven mode deliberately does not 
backfill, and restore-time discovery is not a live admission mechanism. A 
live-and-backfilled path is therefore a third contract, not a replacement for 
either existing path.
   
   I rechecked the current dev baseline and the related work before replying. 
The overlapping PR #11206 is still open, has a failed Build, and requires 
review, so it is not a safe base to code against yet. The closed #12567 PR 
cannot be treated as an available implementation either. Please keep this 
proposal as a design until the state boundary is settled; do not open a 
competing admission implementation in the meantime.
   
   The right v1 constraints are the ones you identified: reject the option at 
validation time unless exactly-once is enabled; make discovery 
enumerator-owned; persist the admitted and in-flight table state together with 
its watermark; and make duplicate admission impossible across a timer tick, 
checkpoint failure, and restore. The stop/restart versus second-server-id 
choice still needs a state-machine test, not just a happy-path explanation.
   
   Before implementation, please add a compact transition table to this issue 
for the crash cuts before snapshot, between low/high watermark capture and 
checkpoint, after checkpoint, and during reader reassignment. The resulting PR 
must include deterministic MySQL CDC E2E coverage for a newly matching table, 
failure/recovery at those cuts, and unchanged existing table_pattern restore 
behaviour. Keep MySQL and OceanBase support claims separate unless both are 
exercised.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to