SEZ9 commented on PR #12710: URL: https://github.com/apache/seatunnel/pull/12710#issuecomment-6229041212
Thanks for keeping the branch current. I diffed the PR-owned files between `d6f7513761` and `bd58ded09c` and none changed; the new commits only bring in unrelated `dev` changes, so there is nothing new to re-read. Status of my earlier points: - **Shutdown semantics on master/worker.** Addressed. `terminationGracePeriodSeconds` is wired in both the master and worker Deployment templates and driven from `values.yaml` (default 30). No `hazelcast.shutdownhook.policy` is set, so the stop is Hazelcast's default `TERMINATE`: the member leaves within seconds and its tasks recover from the last checkpoint. The description and docs already describe it that way (a fast, clean exit from the cluster, not a graceful stop of running jobs), which is what I asked for. - **Docs.** Addressed. Both the en and zh Kubernetes pages lead with the exec-form `command` plus `terminationGracePeriodSeconds`, with `preStop` + `stop-seatunnel-cluster.sh` kept as an optional tip for setups that must stay on `/bin/sh -c`. The one remaining item is non-blocking: a small tracking issue for the `SeaTunnelServer.shutdown` terminate-flag follow-up, linked from the PR description, so it is not lost after merge. Otherwise I have no further asks within the scope of my earlier review. <!-- streview-comment:1821 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
