SEZ9 commented on PR #12578: URL: https://github.com/apache/seatunnel/pull/12578#issuecomment-6245095699
Thanks @hutiefang76 for the follow-up and the pointer to `SeaTunnelRow.java` lines 52–60 at ef53a70c6f72. What you describe matches what I was asking for on the two remaining points: the `size = 0` write only happening inside `if (size != 0)` after the field assignment, and Javadoc on `setField` covering both the invalidation and the `getFields()` / nested-object limitation. I have not re-read that file at this head yet, so I will confirm it against the diff before closing those two out; if it is as described, nothing further is needed on the code. As noted in my previous comment, the test points are already covered. CI remains the only open item. Thanks for checking the Notify job; once a Build run for this head is available and green, I am happy with this from my side, and the final approval still needs a maintainer with write access. <!-- streview-comment:1838 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
