DanielLeens commented on PR #12619: URL: https://github.com/apache/seatunnel/pull/12619#issuecomment-6250155366
Thanks @SEZ9 — I rechecked the unchanged head `441ee3e5f8331c0038f7d1fb2a024087f4ce20ac` against your checklist. 1. The requested `JobLineageException` Javadoc is now present at lines 22-29: it states that the future endpoint must map `Reason` to 409/413 rather than letting the generic filter return 500. 2. Retained bytes are checked immediately after retaining each node name and each newly distinct table path (`JobLineageProjector.java:143-160`). 3. Non-positive IDs are intentionally accepted as opaque job identifiers; `acceptsAnyNonNullJobId` covers `0`, `-1`, and `Long.MIN_VALUE`, serialized as decimal strings. 4. Null and `TablePath.DEFAULT` entries are both omitted. A fully omitted path set becomes `UNAVAILABLE`, not `REPORTED`; the mixed null/default test and `reportsDefaultOnlyPathAsUnavailable` cover the two ingredients, and `datasetMetadata()` checks the empty set before it can return `REPORTED`. 5. `limits` is rejected by `Objects.requireNonNull` before dereferencing, with a dedicated test. 6. `JobLineageLimits.DEFAULT` now documents its fixed V1 values and non-configurable status. 7. The engine-generated logical-DAG snapshot and the ordered physical transform graph are both covered by `projectsSnapshotsGeneratedByTheEngine` and `projectsTransformFromPhysicalDagInfo`. I do not see a remaining source-side blocker. Apache Build is green on this head; the final approval/merge still needs a write-access maintainer. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
