DanielLeens commented on PR #12769: URL: https://github.com/apache/seatunnel/pull/12769#issuecomment-6289489731
Quick status update so this thread does not sit on a stale CI fact. In my last review I noted that the fork Build for head `0a9f92ab66` was still in progress; it has now completed and is passing. The blocker from that review is unchanged, though: GitHub reports this branch as having merge conflicts with `dev` (`mergeable_state: dirty`, 45 commits behind). Please sync with the latest `dev`, resolve the conflicts by keeping `dev`'s NULL-key implementation, and drop the duplicated NULL-key changes and tests from this PR, as described in Issue 1 of my review. After that, please let the required checks rerun on the new head and I will take another pass. The green Build result does not clear the merge-state blocker. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
