dybyte opened a new pull request, #12973:
URL: https://github.com/apache/seatunnel/pull/12973

   Fixes: https://github.com/apache/seatunnel/issues/12972
   
   ### Purpose of this pull request
   
   `FileMapStore` did not persist entry expiration times, so finished jobs (put 
with a TTL) were
   reloaded without one after a full cluster restart and never expired.
   
   - `FileMapStore` is now an `EntryStore`: the expiration time is stored with 
each entry and
     returned on load, and expired entries are skipped.
   - `IMapFileData` gets a trailing optional `expirationTime` field. Old WAL 
records read it as
     "never expires", and older releases skip it.
   
   ### Does this PR introduce _any_ user-facing change?
   
   Finished jobs now expire as configured after a full restart. Entries written 
before this change
   still have no expiration time.
   
   ### How was this patch tested?
   
   Unit tests for the WAL reader and storage, a Hazelcast restart test in 
`FileMapStoreTest`, and
   
`ClusterFaultToleranceIT#testFinishedJobKeepsExpirationTimeAfterAllNodeDown`. 
Both restart tests
   fail without this change.
   
   ### Check list
   
   * [ ] If any new Jar binary package adding in your PR, please add License 
Notice according
     [New License 
Guide](https://github.com/apache/seatunnel/blob/dev/docs/en/developer/new-license.md)
   * [ ] If necessary, please update the documentation to describe the new 
feature. https://github.com/apache/seatunnel/tree/dev/docs
   * [ ] If necessary, please update `incompatible-changes.md` to describe the 
incompatibility caused by this PR.
   * [ ] If you are contributing the connector code, please check that the 
following files are updated:
     1. Update 
[plugin-mapping.properties](https://github.com/apache/seatunnel/blob/dev/plugin-mapping.properties)
 and add new connector information in it
     2. Update the pom file of 
[seatunnel-dist](https://github.com/apache/seatunnel/blob/dev/seatunnel-dist/pom.xml)
     3. Add ci label in 
[label-scope-conf](https://github.com/apache/seatunnel/blob/dev/.github/workflows/labeler/label-scope-conf.yml)
     4. Add e2e testcase in 
[seatunnel-e2e](https://github.com/apache/seatunnel/tree/dev/seatunnel-e2e/seatunnel-connector-v2-e2e/)
     5. Update connector 
[plugin_config](https://github.com/apache/seatunnel/blob/dev/config/plugin_config)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to