davidzollo commented on PR #12316: URL: https://github.com/apache/seatunnel/pull/12316#issuecomment-6394269422
Updated in c5462a14a078f39ca206edf01937af6fe0c65dc1 to address the remaining review points. Timer flushes now use the same announce/finally-withdraw handoff as barriers and recheck closure under the collector monitor. The helper documents cross-poll progress and polling limits, and retains the replaced sleep call's interrupted-thread behavior even on the no-pending fast path. Test registration precedes sampling, with unconditional owned-thread cleanup. The existing test class now exercises actual SourceFlowLifeCycle/collector barrier and timer wiring, serialized state and snapshot/state/ack/forward order, failures and queued ticks behind a closing barrier. BackpressureSlowSinkIT retains its unchanged single-split workload and all original checkpoint/queue assertions, running with timer flushing both disabled and enabled; the timer variant checks actual worker flush-counter progress. No #12313 fixture workaround is included. Scoped Spotless and static whitespace checks passed, and the final source/test patch received independent review. The PR description now reflects the actual scope and limits. Remote readback confirms this head, four intended files, no POM delta and no conflict. Current-head GitHub CI remains required; this is not runtime or merge clearance. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
