DanielLeens commented on PR #12156: URL: https://github.com/apache/seatunnel/pull/12156#issuecomment-6473869916
Thanks @SEZ9 for raising the synchronization boundary explicitly. I rechecked PhysicalPlan on 7938f302fd1f against its base: both versions check status outside the later transition boundary. This PR replaces the ordinal predicate and removes the second cancel-path IMap read; it does not introduce that locking design. The current NOT_STARTED_STATUSES Javadoc already documents the pre-existing check-then-act race and links #12342. I would keep the locking correction in that tracked issue rather than silently broadening this predicate change. My source conclusion remains clear for this scope; current-head CI is a separate gate. Gate snapshot (2026-10-28T15:56:49+00:00), head `7938f302fd1f3ba212993f258bb65d4cc7f58f3b`: [Build](https://github.com/apache/seatunnel/runs/122618193350) is `ACTION_REQUIRED`. The exact blocking stage is **Build workflow-run detection**: the check says no fork Build was found for this SHA. This is not an executed test failure and does not by itself prove that fork Actions is disabled. Open the fork Actions tab, enable workflows if needed, then manually run the existing Build workflow for this PR branch. If a matching run already exists, link it for a maintainer to reconcile the aggregate. No empty commit or speculative dependency change is requested. Upstream check: current dev retains the fork-run adoption workflow and its scheduled/manual status-refresh path. A base sync alone cannot enable fork Actions or supply a missing exact-head workflow run, so I am not prescribing sync as the fix for this activation gate. My [previous source conclusion](https://github.com/apache/seatunnel/pull/12156#pullrequestreview-5660887838) remains clear for the reviewed scope. CI is not being passed by inference, and this follow-up is not an effective approval. Comparison recorded in this scan: base `dev`, `diverged`, ahead 10 / behind 37, no merge conflict. Branch drift is metadata here and is not an additional sync request. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
