DanielLeens commented on PR #11077: URL: https://github.com/apache/seatunnel/pull/11077#issuecomment-6557485919
Thanks @SEZ9. I need to correct my preceding shorthand acknowledgment: it treated your older F1-F8 list as if all those source changes were still absent. That does not match my detailed current-head review or the current code. `MultiTableSink.java:142-174` validates physical row layouts; `:225-228` creates the writer outside computeIfAbsent and preserves IOException; `:248-251` registers every alias's context. MultiTableSinkWriter groups shared instances by identity for snapshot/close and restore merges legacy alias records. Those implemented protections should stay recognized rather than being requested again. The actual open items from my full review are its Issue 2 (EN/ZH migration/release-note accuracy) and Issue 3 (destination-identifier components and metadata-only schema compatibility tests), plus Issue 1's missing exact-head Build. The digest/config-identity hardening remains the same non-blocking trade-off described there. No empty trigger commit is needed: link/start the existing fork Build after the real fixes. GitHub still reports actual merge conflicts, so the author must resolve those against dev while preserving both sides; conflict resolution and CI activation do not close the existing docs/test blockers. This clarifies the unchanged-head discussion and does not issue another full review. Checked 2026-11-01T11:44:58.200735+00:00; unchanged head `8b383c04eeed65c41a14ba756100a33f430124eb`, base `dev`; compare `diverged`, ahead 38 / behind 184; merge `dirty` / `DIRTY`; review decision `REVIEW_REQUIRED`. Behind/diverged is recorded independently and does not itself request a sync. Daniel has READ repository permission. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
