SEZ9 commented on PR #11307:
URL: https://github.com/apache/seatunnel/pull/11307#issuecomment-6593958845
Thanks for the update on head `47ae1be3d4997bd63ad9daffa7f7a8032c5df03a`.
Before I clear my earlier change request, could you briefly confirm how each
of the previous points is handled on this head? I don't see that spelled out in
the thread yet:
- **F1 / F5 (Windows `.cmd` launcher):** `!errorlevel!`/`!CMD!` are now
expanded while delayed expansion is still enabled (so the `call` target is the
real command rather than the literal `!CMD!`), and a failing starter java
process with no stdout now propagates a non-zero exit code instead of exiting 0.
- **F2 / F6 (shell launcher):** whether the `eval` of the config-assembled
command line was changed or hardened, and that `args=$@`, `${args}` and
`${CLASS_PATH}` are now quoted so argument boundaries and globs are preserved.
- **F3 (shaded `seatunnel-translation-spark-3.3`):** the approach taken — a
Catalyst compatibility check against 3.5.8 at build/test time, or a short note
on why runtime detection is acceptable here.
- **F4 (logging jars):** that only one SLF4J binding ends up under
`starter/logging/*` for the Spark 3.5 starter, or how the `log4j-slf4j-impl` /
`log4j-slf4j2-impl` overlap is avoided.
- **F7 (tests):** whether a streaming (micro-batch) test was added for Spark
3.5, or a run of the streaming template on Spark 3.5.8 as evidence.
- **F8 (docs):** that Spark 3.4.x guidance was added alongside the "Spark
3.3.x" wording for `seatunnel-spark-3-starter.jar`.
A short per-item note or pointers to the relevant changes is enough. Once
confirmed, I'll update my review so the PR can move forward.
<!-- streview-comment:2240 -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
