DanielLeens commented on PR #11633: URL: https://github.com/apache/seatunnel/pull/11633#issuecomment-6646229114
Thanks @li3zhi4. A quick update on the CI note in my last review, which said the fork Build for `8b13081fb7` was still queued. That run (https://github.com/li3zhi4/seatunnel/actions/runs/41774074745) has now finished, and the apache-side `Build` check is red. I went through each non-green job on this head: - **All jobs that cover this diff are green.** That includes `unit-test` (JDK 11 and 17, Linux and Windows), where the new format-json tests run, `kafka-connector-it` (11 and 17), where the extended `KafkaFormatIT` and `KafkaJsonDefaultValueIT` run, and `connector-file-local-it (17)`. - `connector-file-local-it (11, ubuntu-latest)` shows **cancelled**, but the log shows that every test passed: `Tests run: 109, Failures: 0, Errors: 0`, `BUILD SUCCESS`, `Total time: 01:57 h`. The job then hit its 120-minute `timeout-minutes` limit at the very end. Another file-connector PR ran this lane today in about 108 minutes, so this full LocalFile suite runs very close to that limit. It is a time-budget cancellation, not a test failure. - `jdbc-connectors-it-part-7` (11 and 17): `MetalakeIT.startUp` (`MetalakeIT.java:158`). The Gravitino server it downloads and starts inside the container never answered on port 8090 within 180 seconds. The same failure hit several unrelated PRs today, and this PR does not touch JDBC or Gravitino. - `all-connectors-it-5 (11, ubuntu-latest)`: `TiDBCDCIT.startUp` -> `TiDBTestBase.initializeTidbTable:213` failed with a MySQL `CommunicationsException` while it was connecting to the TiDB container. The same job passed on JDK 17, and this PR does not touch TiDB. None of these failures comes from this diff, and `dev` has no fix for them yet, so a `dev` sync would not help. The cheapest next step is "Re-run failed jobs" on that run. No code change is needed. My conclusion is unchanged: there are no non-CI blockers, and I will approve once `Build` is green on this head. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
