goutamadwant commented on PR #11814: URL: https://github.com/apache/seatunnel/pull/11814#issuecomment-6651162546
@SEZ9 Checked each item against the current head (line numbers at that SHA): - **F1**: `createSeaTunnelServer` calls `executeExtraCommands(server)` at `SeaTunnelContainer.java:162`, then `server.start()` at `:164`. So the wait set at `FakeSourceToConsoleWithEventReportIT.java:114-125` is installed before start. The config copied in the same hook (`:108-110`) also depends on that order, and the test receives events. - **F2**: the final flush runs only if the scheduler terminated and the thread wasn't interrupted (`JobEventHttpReportHandler.java:238`). `finally` cancels in-flight calls before `evictAll()` (`:264-265`). - **F3**: both flushes catch `Exception` (`:242`, `:257`) and the interrupt flag is restored (`:266-267`). Covered by tests at `JobEventHttpReportHandlerTest.java:127` and `:398`. - **F4**: `seatunnel-engine-server/pom.xml:30-41` imports `kotlin-bom` 1.9.10. - **F5**: the test calls `report()` explicitly (`:220-221`), bounds `takeRequest` at 10s (`:223-224`) and closes the buffers (`:227-228`). - **F6**: `known-dependencies.txt` lists only 1.9.10 and the dependency check passes. The Kubernetes block in `release-docs/LICENSE` still said 1.8.21; fixed in `fbd73878d6`. - **F7**: redirects are disabled at `JobEventHttpReportHandler.java:284-285`, tested at test `:238` and documented in `event-listener.md`. - **F8**: the okhttp 2.7.5 overload also appended `; charset=utf-8`, so the header is unchanged. `testReportEvent` asserts it (`:190`). Is anything still blocking? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
