Vivek1106-04 commented on issue #13052: URL: https://github.com/apache/seatunnel/issues/13052#issuecomment-6702780038
@KaustAbhinand @SEZ9 Sorry for not flagging this here sooner: I already have a fix for this issue, so I would like to keep it and avoid us duplicating work. The fix is commit `f1c125f62` on [`fix-coordinator-error-generation`](https://github.com/Vivek1106-04/seatunnel/tree/fix-coordinator-error-generation) in my fork. It adds an owner-checked `handleCoordinatorError` under `generationLock`, with the owner captured in the deferred trigger, completion, barrier and checkpoint-id handlers, plus 4 new tests in `CheckpointCoordinatorTest`. It is stacked on #12165, because `generationLock` comes from that PR, so it cannot open cleanly against `dev` until #12165 merges. That is why no PR exists yet. It also needs a rebase onto `dev` at that point, since it sits on the earlier #12165 head `a932e27a7`. The #12165 review also agreed that two small scheduler and test nits go into this follow-up. @KaustAbhinand if you have already started, please tell me so we can compare approaches. Review of the branch is very welcome either way, especially on the handlers I left on the old path (`notifyCompleted`, `reportCheckpointErrorFromTask` and `task running failed`), because they are synchronous or their generation is ambiguous. @SEZ9 I will check the PR against the asks in your last comment when I open it. Your earlier note that you would review it once #12165 merges still fits this plan. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
