zhangshenghang commented on PR #12993:
URL: https://github.com/apache/seatunnel/pull/12993#issuecomment-6756992966

   Both blockers are fixed in fff6003a7 (both languages):
   
   - **Issue 1 (pagination)**: the `pageing` section on all four pages now 
states explicitly that these options are **not applied by this connector** — 
`GithubSource` / `GitlabSource` build their readers without a pagination 
context, so the source always reads a single page regardless of `pageing` 
settings while the job still succeeds, and that reading more data requires 
connector support to be added. The task examples no longer use a `pageing` 
block or a `${page}` placeholder (they read a single page explicitly with `page 
= "1"`).
   - **Issue 2 (binary)**: the `binary_chunk_size` option row and its section 
are removed, and the `format` description now says `json` and `text` only.
   
   An empty "Trigger CI" commit (d7c616e1d) was pushed on top so the fork's 
Build workflow runs on the new head. Issues 3 and 4 remain untouched as agreed 
(non-blocking).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to